Open jobs #740
Merged
Open jobs #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
requested changes
Aug 17, 2024
There was a problem hiding this comment.
Awesome! ❤️
And even though it was a 1k line commit as usual 😂 This time it was relatively easy to review :)
A few additional comments:
- When I try to submit into a closed job, it crashes with a backtrace:
./hq job submit hostname
./hq job submit --job 1 hostname
Error: Received error: "Job 1 is not open"
<backtrace>
Same when a job is not found and when you attach an array job with a task ID that already exists. It should print some nicer error instead.
- When a new submit is attached to an existing job, we should print a different message than this:
Job submitted successfully, job ID: 2. It should say something like "New task(s) were attached to job 2".
|
Kobzol
reviewed
Aug 20, 2024
|
I think that all issues have been resolved. |
Kobzol
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implemented open jobs.
NOT IMPLEMENTED YET: Dependencies between different submits into the same job. The server & scheduler is ready for this, mostly what is missing is to prepare an interface for submitting such tasks).